From 14ef48ac43d62c3479c475dfb6b413ccad3d172c Mon Sep 17 00:00:00 2001
From: Jonas Eberle <flightvision@googlemail.com>
Date: Sat, 28 Mar 2020 21:12:01 +0100
Subject: [PATCH] [BUGFIX] Fix TypeError in AssetCollector if identifier is
numeric
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Although registered as "string" argument in the ViewHelper, an incoming
string that is_numeric() is cast to an integer, leading to a TypeError.
Resolves: #90873
Releases: master
Change-Id: Ic2b0cd8df1a75c46a22a605d6f7e3a0e2438a1d6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63993
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
---
typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php | 2 +-
.../sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php
index 8911f08d8496..532974e2000f 100644
--- a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php
+++ b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/CssViewHelper.php
@@ -84,7 +84,7 @@ class CssViewHelper extends AbstractTagBasedViewHelper
public function render(): string
{
- $identifier = $this->arguments['identifier'];
+ $identifier = (string)$this->arguments['identifier'];
$attributes = $this->tag->getAttributes();
$file = $this->tag->getAttribute('href');
unset($attributes['href']);
diff --git a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php
index 0dd97ad46de1..086c7f8d1299 100644
--- a/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php
+++ b/typo3/sysext/fluid/Classes/ViewHelpers/Asset/ScriptViewHelper.php
@@ -80,7 +80,7 @@ class ScriptViewHelper extends AbstractTagBasedViewHelper
public function render(): string
{
- $identifier = $this->arguments['identifier'];
+ $identifier = (string)$this->arguments['identifier'];
$attributes = $this->tag->getAttributes();
$src = $this->tag->getAttribute('src');
unset($attributes['src']);
--
GitLab