From 10d1fc78e9e466f8f543cc0857a626461875e765 Mon Sep 17 00:00:00 2001
From: Helmut Hummel <typo3@helhum.io>
Date: Thu, 5 Jan 2023 12:50:45 +0100
Subject: [PATCH] [BUGFIX] Fix array access warning in SystemStatusUpdateTask
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
When this task is executed on CLI (scheduler), the global request variable
is not available, thus a null check must be added before checking the instance
of the value.
Releases: 10.4, 11.5, main
Resolves: #99464
Change-Id: Ie9c1b8e4fbc187d6ade569b1b152ce799a09a1f0
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77221
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
---
typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php b/typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php
index eed357086f7e..91a9674685c6 100644
--- a/typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php
+++ b/typo3/sysext/reports/Classes/Task/SystemStatusUpdateTask.php
@@ -125,7 +125,7 @@ class SystemStatusUpdateTask extends AbstractTask
->subject($subject)
->setTemplate('Report')
->assign('message', $message);
- if ($GLOBALS['TYPO3_REQUEST'] instanceof ServerRequestInterface) {
+ if (($GLOBALS['TYPO3_REQUEST'] ?? null) instanceof ServerRequestInterface) {
$email->setRequest($GLOBALS['TYPO3_REQUEST']);
}
--
GitLab