From 0ffc91c442a45784bedddc1981bf9b7aa7482a0f Mon Sep 17 00:00:00 2001
From: Helmut Hummel <typo3@helhum.io>
Date: Wed, 28 Feb 2018 13:41:49 +0100
Subject: [PATCH] [BUGFIX] Avoid renumbering array keys on writing
configuration
Renumbering array keys, even if all keys are integer
is a destructive operation.
Doing so at least breaks our logging configuration,
which uses LogLevel constants as array keys and these constants
are defined as integer.
Therefore this pure visual optimization is removed
when writing LocalConfiguration.php
At a later point we might consider deprecating this
method, which at least has a wrong method name
(mentions "numeric", while it meanwhile uses "int" checks).
As this method performs a destructive operation,
its usefulness is limited.
Resolves: #82304
Releases: master, 8.7, 7.6
Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d
Reviewed-on: https://review.typo3.org/55944
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
---
.../core/Classes/Configuration/ConfigurationManager.php | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/typo3/sysext/core/Classes/Configuration/ConfigurationManager.php b/typo3/sysext/core/Classes/Configuration/ConfigurationManager.php
index 071ffa564e9c..4ba9e73e9c2a 100644
--- a/typo3/sysext/core/Classes/Configuration/ConfigurationManager.php
+++ b/typo3/sysext/core/Classes/Configuration/ConfigurationManager.php
@@ -322,9 +322,7 @@ class ConfigurationManager
$localConfigurationFile,
'<?php' . LF .
'return ' .
- ArrayUtility::arrayExport(
- ArrayUtility::renumberKeysToAvoidLeapsIfKeysAreAllNumeric($configuration)
- ) .
+ ArrayUtility::arrayExport($configuration) .
';' . LF,
true
);
--
GitLab