From 0d1723abe4dc2ae2136a9891bbf75b2b31abac47 Mon Sep 17 00:00:00 2001 From: Georg Ringer <georg.ringer@gmail.com> Date: Tue, 1 Oct 2019 04:19:43 +0200 Subject: [PATCH] [TASK] Use attribute translate="no" for non translatable strings If a string is used in a XLIFF file but it should not be translated, it must be identified as such. The XLIFF standard provides the attribute "translate", see http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#translate. The big advantage is that translators on Crowdin don't even see those labels anymore. Resolves: #89318 Releases: master, 9.5 Change-Id: Ibe26d3524254ce0ef8404a96e412c2b15d0978be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61867 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by: Susanne Moog <look@susi.dev> --- .../belog/Resources/Private/Language/locallang.xlf | 12 ++++++------ .../Resources/Private/Language/locallang_wizards.xlf | 10 +++++----- .../Resources/Private/Language/locallang.xlf | 4 ++-- .../Resources/Private/Language/locallang_db.xlf | 4 ++-- .../Private/Language/locallang_browse_links.xlf | 2 +- 5 files changed, 16 insertions(+), 16 deletions(-) diff --git a/typo3/sysext/belog/Resources/Private/Language/locallang.xlf b/typo3/sysext/belog/Resources/Private/Language/locallang.xlf index 650d5e56b05d..19eeacd238cb 100644 --- a/typo3/sysext/belog/Resources/Private/Language/locallang.xlf +++ b/typo3/sysext/belog/Resources/Private/Language/locallang.xlf @@ -54,22 +54,22 @@ <trans-unit id="set" resname="set"> <source>Set</source> </trans-unit> - <trans-unit id="20" resname="20"> + <trans-unit id="20" resname="20" translate="no"> <source>20</source> </trans-unit> - <trans-unit id="50" resname="50"> + <trans-unit id="50" resname="50" translate="no"> <source>50</source> </trans-unit> - <trans-unit id="100" resname="100"> + <trans-unit id="100" resname="100" translate="no"> <source>100</source> </trans-unit> - <trans-unit id="200" resname="200"> + <trans-unit id="200" resname="200" translate="no"> <source>200</source> </trans-unit> - <trans-unit id="500" resname="500"> + <trans-unit id="500" resname="500" translate="no"> <source>500</source> </trans-unit> - <trans-unit id="1000" resname="1000"> + <trans-unit id="1000" resname="1000" translate="no"> <source>1000</source> </trans-unit> <trans-unit id="actionAll" resname="actionAll"> diff --git a/typo3/sysext/core/Resources/Private/Language/locallang_wizards.xlf b/typo3/sysext/core/Resources/Private/Language/locallang_wizards.xlf index b36ea1430463..abba83508b3e 100644 --- a/typo3/sysext/core/Resources/Private/Language/locallang_wizards.xlf +++ b/typo3/sysext/core/Resources/Private/Language/locallang_wizards.xlf @@ -297,19 +297,19 @@ <trans-unit id="imwizard.set-aspect-ratio" resname="imwizard.set-aspect-ratio"> <source>Set Aspect Ratio</source> </trans-unit> - <trans-unit id="imwizard.ratio.16_9" resname="imwizard.ratio.16_9"> + <trans-unit id="imwizard.ratio.16_9" resname="imwizard.ratio.16_9" translate="no"> <source>16:9</source> </trans-unit> - <trans-unit id="imwizard.ratio.3_2" resname="imwizard.ratio.3_2"> + <trans-unit id="imwizard.ratio.3_2" resname="imwizard.ratio.3_2" translate="no"> <source>3:2</source> </trans-unit> - <trans-unit id="imwizard.ratio.4_3" resname="imwizard.ratio.4_3"> + <trans-unit id="imwizard.ratio.4_3" resname="imwizard.ratio.4_3" translate="no"> <source>4:3</source> </trans-unit> - <trans-unit id="imwizard.ratio.1_1" resname="imwizard.ratio.1_1"> + <trans-unit id="imwizard.ratio.1_1" resname="imwizard.ratio.1_1" translate="no"> <source>1:1</source> </trans-unit> - <trans-unit id="imwizard.ratio.191_1" resname="imwizard.ratio.191_1"> + <trans-unit id="imwizard.ratio.191_1" resname="imwizard.ratio.191_1" translate="no"> <source>1.91:1</source> </trans-unit> <trans-unit id="imwizard.ratio.free" resname="imwizard.ratio.free"> diff --git a/typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf b/typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf index 4ddb44c4523d..2330ba09ff5d 100644 --- a/typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf +++ b/typo3/sysext/dashboard/Resources/Private/Language/locallang.xlf @@ -128,7 +128,7 @@ <source>More TYPO3 news</source> </trans-unit> - <trans-unit id="widgets.t3information.title" xml:space="preserve"> + <trans-unit id="widgets.t3information.title" xml:space="preserve" translate="no"> <source>TYPO3</source> </trans-unit> <trans-unit id="widgets.t3information.description" xml:space="preserve"> @@ -184,7 +184,7 @@ <trans-unit id="widget_group.general" xml:space="preserve"> <source>General</source> </trans-unit> - <trans-unit id="widget_group.typo3" xml:space="preserve"> + <trans-unit id="widget_group.typo3" xml:space="preserve" translate="no"> <source>TYPO3</source> </trans-unit> <trans-unit id="widget_group.documentation" xml:space="preserve"> diff --git a/typo3/sysext/indexed_search/Resources/Private/Language/locallang_db.xlf b/typo3/sysext/indexed_search/Resources/Private/Language/locallang_db.xlf index 3bf57449604c..199a412e569c 100644 --- a/typo3/sysext/indexed_search/Resources/Private/Language/locallang_db.xlf +++ b/typo3/sysext/indexed_search/Resources/Private/Language/locallang_db.xlf @@ -12,7 +12,7 @@ <trans-unit id="index_config.description" resname="index_config.description"> <source>Description</source> </trans-unit> - <trans-unit id="index_config.type.I.0" resname="index_config.type.I.0"> + <trans-unit id="index_config.type.I.0" resname="index_config.type.I.0" translate="no"> <source>-</source> </trans-unit> <trans-unit id="index_config.type.I.1" resname="index_config.type.I.1"> @@ -39,7 +39,7 @@ <trans-unit id="index_config.table2index" resname="index_config.table2index"> <source>Table to index</source> </trans-unit> - <trans-unit id="index_config.table2index.I.0" resname="index_config.table2index.I.0"> + <trans-unit id="index_config.table2index.I.0" resname="index_config.table2index.I.0" translate="no"> <source>-</source> </trans-unit> <trans-unit id="index_config.alternative_source_pid" resname="index_config.alternative_source_pid"> diff --git a/typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf b/typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf index 9fed7402d7f3..c81e4de690ca 100644 --- a/typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf +++ b/typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf @@ -93,7 +93,7 @@ <trans-unit id="setLink" resname="setLink"> <source>Set Link</source> </trans-unit> - <trans-unit id="urlPlaceholder" resname="urlPlaceholder"> + <trans-unit id="urlPlaceholder" resname="urlPlaceholder" translate="no"> <source>https://...</source> </trans-unit> <trans-unit id="clickToRedrawFullSize" resname="clickToRedrawFullSize"> -- GitLab