From 075b0931e00b785d62ee9e01be82d58e7090c722 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Elias=20H=C3=A4u=C3=9Fler?= <elias@haeussler.dev>
Date: Sun, 3 Sep 2023 18:01:22 +0200
Subject: [PATCH] [BUGFIX] Re-add field explanation text for form finisher
checkboxes
This patch re-adds support for the `fieldExplanationText` property of
form finisher checkboxes. It was removed with #95086, but is actually
still used in some finishers, e.g. email finisher. Said patch also
introduced wrong HTML for the checkbox label, which is fixed as well.
Resolves: #101831
Related: #95086
Releases: main, 12.4
Change-Id: Ia1fe626ee5375f6d13adad8274b04be28345ed65
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80843
Tested-by: Benjamin Franzke <ben@bnf.dev>
Tested-by: core-ci <typo3@b13.com>
Reviewed-by: Benjamin Franzke <ben@bnf.dev>
---
.../Backend/Partials/FormEditor/Inspector/CheckboxEditor.html | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html b/typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html
index 06d78491d9a0..130c14c9727b 100644
--- a/typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html
+++ b/typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/CheckboxEditor.html
@@ -1,9 +1,10 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers" xmlns:formvh="http://typo3.org/ns/TYPO3/CMS/Form/ViewHelpers" data-namespace-typo3-fluid="true">
<div class="form-editor">
<div class="t3-form-control-group form-group">
- <label class="form-label t3js-formengine-label data-random-id data-random-id-attribute="for" data-random-id-number="1">
+ <label class="form-label t3js-formengine-label" data-random-id data-random-id-attribute="for" data-random-id-number="1">
<span data-template-property="label"></span>
</label>
+ <div data-template-property="fieldExplanationText" class="form-description"></div>
<div class="form-check form-switch" data-identifier="inspectorEditorControlsWrapper">
<input class="form-check-input" data-random-id data-random-id-attribute="id" data-random-id-number="1" type="checkbox" />
<label class="form-check-label" data-random-id data-random-id-attribute="for" data-random-id-number="1"></label>
--
GitLab