From 0615ba7c26369fe36f06dc0d3f11be00d4b66c50 Mon Sep 17 00:00:00 2001
From: Benni Mack <benni@typo3.org>
Date: Thu, 7 Feb 2019 09:28:09 +0100
Subject: [PATCH] [BUGFIX] Revert Set controller in ExtbasePluginEnhancer"
The accepted change adds an ugly side-effect when using
the same controller/action in multiple route variants.
This reverts commit 977ed578d04a3c2094cdad3207b5d9f86322f326.
Resolves: #87668
Reverts: #87337
Releases: master, 9.5
Change-Id: I7167b42cb26538e676256c9d2e36d1ec18f2bd40
Reviewed-on: https://review.typo3.org/59658
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
---
.../extbase/Classes/Routing/ExtbasePluginEnhancer.php | 7 -------
1 file changed, 7 deletions(-)
diff --git a/typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php b/typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php
index 62ebfde7d501..c24ed9ee5864 100644
--- a/typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php
+++ b/typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php
@@ -124,13 +124,6 @@ class ExtbasePluginEnhancer extends PluginEnhancer
/** @var Route $defaultPageRoute */
$defaultPageRoute = $collection->get('default');
foreach ($this->routesOfPlugin as $configuration) {
- if (!empty($configuration['_controller'])) {
- $this->applyControllerActionValues(
- $configuration['_controller'],
- $originalParameters[$this->namespace]
- );
- }
-
$variant = $this->getVariant($defaultPageRoute, $configuration);
// The enhancer tells us: This given route does not match the parameters
if (!$this->verifyRequiredParameters($variant, $originalParameters)) {
--
GitLab