From 053e9e3c771c2a80878c1e836f49a37fd5c786fb Mon Sep 17 00:00:00 2001 From: Jo Hasenau <info@cybercraft.de> Date: Sat, 5 Mar 2016 17:55:38 +0100 Subject: [PATCH] [BUGFIX] Reinsert ommitted vars for ternary operators When the check is done with multiple variables omitting the first part of a ternary operator just inserts the boolean result of the check but not the variable Change-Id: If683770435995cac079fb2fd42344ba1cc15a08f Resolves: #70242 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/47108 Reviewed-by: Daniel Goerz <ervaude@gmail.com> Tested-by: Daniel Goerz <ervaude@gmail.com> Tested-by: Karthikeyan Palaniswamy <karthikeyan@forethought.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> --- .../rtehtmlarea/Classes/Form/Element/RichTextElement.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php b/typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php index c58ada897711..088db4589fd3 100644 --- a/typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php +++ b/typo3/sysext/rtehtmlarea/Classes/Form/Element/RichTextElement.php @@ -308,7 +308,7 @@ class RichTextElement extends AbstractFormElement $inlineStackProcessor->initializeByGivenStructure($this->data['inlineStructure']); $inlineStructureDepth = $inlineStackProcessor->getStructureDepth(); $width -= $inlineStructureDepth > 0 ? ($inlineStructureDepth + 1) * 12 : 0; - $widthOverride = isset($backendUser->uc['rteWidth']) && trim($backendUser->uc['rteWidth']) ?: trim($this->processedRteConfiguration['RTEWidthOverride']); + $widthOverride = isset($backendUser->uc['rteWidth']) && trim($backendUser->uc['rteWidth']) ? trim($backendUser->uc['rteWidth']) : trim($this->processedRteConfiguration['RTEWidthOverride']); if ($widthOverride) { if (strstr($widthOverride, '%')) { if ($this->client['browser'] !== 'msie') { @@ -320,7 +320,7 @@ class RichTextElement extends AbstractFormElement } $width = strstr($width, '%') ? $width : $width . 'px'; $height = 380 + (isset($options['RTELargeHeightIncrement']) ? (int)$options['RTELargeHeightIncrement'] : 0); - $heightOverride = isset($backendUser->uc['rteHeight']) && (int)$backendUser->uc['rteHeight'] ?: (int)$this->processedRteConfiguration['RTEHeightOverride']; + $heightOverride = isset($backendUser->uc['rteHeight']) && (int)$backendUser->uc['rteHeight'] ? (int)$backendUser->uc['rteHeight'] : (int)$this->processedRteConfiguration['RTEHeightOverride']; $height = $heightOverride > 0 ? $heightOverride . 'px' : $height . 'px'; $paddingRight = '2'; $editorWrapWidth = '99%'; -- GitLab