From 03b08c7e18c0e481fe39cbac9c8eb130e9bb0ada Mon Sep 17 00:00:00 2001
From: Sebastian Hofer <sebastian.hofer@marit.ag>
Date: Mon, 27 Nov 2017 12:47:11 +0100
Subject: [PATCH] [BUGFIX] fix missing l18n fields in blog tag table
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The field l18n_parent was missing in table
tx_blogexample_domain_model_tag, but configured in TCA.
This causes an exception with adding a new tag in BE.
Also the field l18n_diffsource was missing in TCA and database.

* Add the fields l18n_parent and l18_diffsource to
  the databse table tx_blogexample_domain_model_tag
* Add TCA configuration for field l18n_diffsource to
  tx_blogexample_domain_model_tag TCA

Also add missing icon and label for
tx_blogexample_domain_model_dateexample.

Remove "allow tables on standard pages". This is not
necessary.

Fixes: #83113
Releases: master, 8.7
Change-Id: I10f809cc4b00df07c6e5a064bb89018578f3abf3
Reviewed-on: https://review.typo3.org/54786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
---
 .../TCA/tx_blogexample_domain_model_tag.php       |   6 ++++++
 .../Resources/Private/Language/locallang_db.xml   |   1 +
 ...on_tx_blogexample_domain_model_dateexample.gif | Bin 0 -> 398 bytes
 .../Extensions/blog_example/ext_tables.php        |   4 ----
 .../Extensions/blog_example/ext_tables.sql        |   2 ++
 5 files changed, 9 insertions(+), 4 deletions(-)
 create mode 100644 typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Public/Icons/icon_tx_blogexample_domain_model_dateexample.gif

diff --git a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php
index 3d57b5c6e38c..784017489976 100644
--- a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php
+++ b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php
@@ -45,6 +45,12 @@ return [
                 'foreign_table_where' => 'AND tx_blogexample_domain_model_tag.uid=###REC_FIELD_l18n_parent### AND tx_blogexample_domain_model_tag.sys_language_uid IN (-1,0)',
             ]
         ],
+        'l18n_diffsource' => [
+            'config'=>[
+                'type' => 'passthrough',
+                'default' => '',
+            ],
+        ],
         'hidden' => [
             'exclude' => true,
             'label' => 'LLL:EXT:lang/Resources/Private/Language/locallang_general.xml:LGL.hidden',
diff --git a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml
index f2be39469cc9..feeef2e08c96 100644
--- a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml
+++ b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Private/Language/locallang_db.xml
@@ -39,6 +39,7 @@
 			<label index="tx_blogexample_domain_model_tag">Tag</label>
 			<label index="tx_blogexample_domain_model_tag.name">Name</label>
 			<label index="tx_blogexample_domain_model_tag.posts">Related posts</label>
+			<label index="tx_blogexample_domain_model_dateexample">Date example</label>
 			<label index="fe_users.tx_extbase_type.Tx_BlogExample_Domain_Model_Administrator">Blog Admin (BlogExample)</label>
 		</languageKey>
 	</data>
diff --git a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Public/Icons/icon_tx_blogexample_domain_model_dateexample.gif b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Resources/Public/Icons/icon_tx_blogexample_domain_model_dateexample.gif
new file mode 100644
index 0000000000000000000000000000000000000000..a8af19847b8ca6be1e8b19d4c4ad1477a77f87f7
GIT binary patch
literal 398
zcmZ?wbhEHb6krfwSjxcQlJ#WHrZ+i#Z_Zr%(zEDIOw*Gs$G$vy^`~am8=tZ#cOLy&
zv+v8Eb6<Rlp43cxbLHNjDXZS(bUk_V>5os|lQp}(l=Qv1a_dV<)0382Z;qV%GH2bJ
zFQ5Ln<ULuk?aP^4U-q2(5>oZ#$+JIO4t<%j?oG+0Hz{pTTIRhua_P&LZ-4&(|Ia`%
zQ2fcl$iSe<paU`q<R=EU)d!}02o#bEp4cAPxS~dCX4jTO88uoQu8a&n8mwaS7`{9d
zQ;TU~6k%)Nk<e?uyzaI-M@QZH>&nl>g!uWzn&tT0`Gw>f7`eGs*w_TwRQegkdbwFj
zWH{OQrq7fSV`OHMkYi?0Qd3u-(W}8H<-{PStf9fk->b$d!^_LSA+9E|aS0<kmx}xX
q4HkCxlX7BGj8ZplFy58x;hoX^xaH~6Fy3N@3>o3K#Rugb8LR;`V3W-N

literal 0
HcmV?d00001

diff --git a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php
index 9eb5ba412de1..dd234d19ffe7 100644
--- a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php
+++ b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.php
@@ -8,10 +8,6 @@ defined('TYPO3_MODE') or die();
 
 \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerPlugin($_EXTKEY, 'Blogs', 'Blog listing');
 
-\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::allowTableOnStandardPages(
-    'tx_blogexample_domain_model_blog,tx_blogexample_domain_model_post,tx_blogexample_domain_model_comment,tx_blogexample_domain_model_person,tx_blogexample_domain_model_tag'
-);
-
 // Categorize Blog,Post records
 \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::makeCategorizable($_EXTKEY, 'tx_blogexample_domain_model_blog');
 \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::makeCategorizable($_EXTKEY, 'tx_blogexample_domain_model_post');
diff --git a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql
index 1db0eac634f2..e04333ad3141 100644
--- a/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql
+++ b/typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/ext_tables.sql
@@ -155,6 +155,8 @@ CREATE TABLE tx_blogexample_domain_model_tag (
 	hidden tinyint(4) unsigned DEFAULT '0' NOT NULL,
 
 	sys_language_uid int(11) DEFAULT '0' NOT NULL,
+	l18n_parent int(11) DEFAULT '0' NOT NULL,
+	l18n_diffsource mediumblob,
 
 	PRIMARY KEY (uid),
 	KEY parent (pid)
-- 
GitLab