From 0311f671e3fc3eab3f04b3d18f1d05861faf12fa Mon Sep 17 00:00:00 2001
From: Sybille Peters <sypets@gmx.de>
Date: Wed, 18 Sep 2019 09:40:32 +0200
Subject: [PATCH] [BUGFIX] Use latest slug in PopulatePageSlug
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
PopulatePageSlug is an upgrade wizard which migrates existing slugs
from realurl tables to the table pages.slug.
In realurl, when the page title changed, the realurl slug changed
(if not fixed). Realurl handled this by adding temporary entries to
its tables which would be used to redirect the URL to its new location.
These entries had a fixed expiration date (expire > 0). The final
slug had no expiration date (expire = 0)
The previous behaviour in PopulatePageSlug preferred entries from
tx_realurl_pathdata with an expiration date (expire > 0) over
entries without (expire = 0). This would prefer (temporary) entries
that were only used for the redirects over the final slug.
This patch uses the 'uid' for sorting in descending order, which
will always use the latest entry for a specific page / language
combinations.
Resolves: #89194
Related: #89964
Releases: master, 9.5
Change-Id: Ica18bf5c6df9d101ccfce7712eae9c979e558a11
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Albrecht Koehnlein <ak@koehnlein.eu>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Albrecht Koehnlein <ak@koehnlein.eu>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
---
typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php b/typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php
index 20ce51548a6c..2f083e66f6a3 100644
--- a/typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php
+++ b/typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php
@@ -233,7 +233,7 @@ class PopulatePageSlugs implements UpgradeWizardInterface
$queryBuilder->expr()->gt('expire', $queryBuilder->createNamedParameter($currentTimestamp))
)
)
- ->orderBy('expire', 'DESC')
+ ->orderBy('uid', 'DESC')
->execute();
$suggestedSlugs = [];
while ($row = $statement->fetch()) {
--
GitLab